sc2mpd / Tickets / #3 OpenHome compile error

#3 OpenHome compile error

Milestone:

Status:

Owner:

Labels:

Mark as Private

Updated: 2017-09-27

Created: 2017-08-25

Creator: Anonymous

Preview Formatting Help

In Fedora 26 and gcc (GCC) 7.1.1 20170622 (Red Hat 7.1.1-3), OpenHome compile has been failed.

gcc -o Build/Obj/Posix/Release/OptionParser.o -c -fexceptions -Wall  -pipe -D_GNU_SOURCE -D_REENTRANT -DDEFINE_LITTLE_ENDIAN -DDEFINE_TRACE -g -O2 -fvisibility=hidden -Wno-psabi  -fPIC -std=c++0x -Werror -IBuild/Include/  OpenHome/TestFramework/OptionParser.cpp
OpenHome/TestFramework/OptionParser.cpp: In member function 'void OpenHome::TestFramework::OptionParser::SetUsage(const TChar*)':
OpenHome/TestFramework/OptionParser.cpp:285:30: error: argument 1 null where non-null expected [-Werror=nonnull]
     iUsage = new TChar[strlen(iUsage)];
                        ~~~~~~^~~~~~~~
In file included from Build/Include/OpenHome/FunctorMsg.h:6:0,
                 from Build/Include/OpenHome/Private/TestFramework.h:8,
                 from OpenHome/TestFramework/OptionParser.cpp:4:
/usr/include/string.h:394:15: note: in a call to function 'size_t strlen(const char*)' declared here
 extern size_t strlen (const char *__s)
               ^~~~~~
cc1plus: all warnings being treated as errors
make: *** [Common.mak:447: Build/Obj/Posix/Release/OptionParser.o] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.M7wv0P (%build)

I would like to add an attachment

Anonymous

Preview Formatting Help

Cancel

Milestone: None

Status: closed

Owner: nobody

Labels: None

Updated: 2017-09-27

Created: 2017-08-25

Creator: Anonymous

Private: No

In Fedora 26 and gcc (GCC) 7.1.1 20170622 (Red Hat 7.1.1-3), OpenHome compile has been failed.

gcc -o Build/Obj/Posix/Release/OptionParser.o -c -fexceptions -Wall -pipe -D_GNU_SOURCE -D_REENTRANT -DDEFINE_LITTLE_ENDIAN -DDEFINE_TRACE -g -O2 -fvisibility=hidden -Wno-psabi -fPIC -std=c++0x -Werror -IBuild/Include/ OpenHome/TestFramework/OptionParser.cpp
OpenHome/TestFramework/OptionParser.cpp: In member function 'void OpenHome::TestFramework::OptionParser::SetUsage(const TChar)':
OpenHome/TestFramework/OptionParser.cpp:285:30: error: argument 1 null where non-null expected [-Werror=nonnull]
iUsage = new TChar[strlen(iUsage)];
In file included from Build/Include/OpenHome/FunctorMsg.h:6:0,
from Build/Include/OpenHome/Private/TestFramework.h:8,
from OpenHome/TestFramework/OptionParser.cpp:4:
/usr/include/string.h:394:15: note: in a call to function 'size_t strlen(const char)' declared here
extern size_t strlen (const char __s)
^~~~~~
cc1plus: all warnings being treated as errors
make: ** [Common.mak:447: Build/Obj/Posix/Release/OptionParser.o] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.M7wv0P (%build)

Discussion

medoc
2017-08-28

Hi,

I'll have a look at this. Can you tell me exactly what OpenHome source code you are building (how did you arrive to this error) ?

Reply
Link Attach

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Preview Edit Formatting Help
  
  Cancel Add attachment
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.
- Sanghoon
  2017-09-01
  
  @medoc
  
  I attached full error log. I tried to build RPM with spec. Please see my attachment.
  
  Attachments
  
  sc2mpd_build_error.txt
  
  Reply
  Link Attach
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Anonymous
    
    Preview Edit Formatting Help
    
    Cancel Add attachment
    You seem to have CSS turned off. Please don't fill out this field.
    
    You seem to have CSS turned off. Please don't fill out this field.

medoc
2017-09-01
There is a typo in the file ohNet/OpenHome/TestFramework/OptionParser.cpp, line 285

You need to replace:

iUsage = new TChar[strlen(iUsage)];

With
iUsage = new TChar[strlen(aUsage)];

I have no time to install fedora 26 or fix the tar file at the moment, but this should enable a manual build.
Reply
Link Attach

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Preview Edit Formatting Help
  
  Cancel Add attachment
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.
- Sanghoon
  2017-09-01
  
  Thank you. I made rpm file and attached src.rpm file. One patch file was added and some modify .spec file to apply modification your correct code.
  
  Attachments
  
  sc2mpd-1.1.1-1.fc26.src.rpm
  
  Reply
  Link Attach
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Anonymous
    
    Preview Edit Formatting Help
    
    Cancel Add attachment
    You seem to have CSS turned off. Please don't fill out this field.
    
    You seem to have CSS turned off. Please don't fill out this field.

medoc
2017-09-02

Thanks ! I'll use your patch until I can make a new release.

Reply
Link Attach

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Preview Edit Formatting Help
  
  Cancel Add attachment
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.
- Anonymous
  2017-09-13
  
  I got same error and now fixed. Thank you guys :)
  
  Preview Edit Formatting Help
  I got same error and now fixed. Thank you guys :)
  
  Cancel Add attachment
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.
  
  New Attachment:
  
  Reply
  Link Edit
  Delete
  
  Approve
  
  Spam
  Attach
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Anonymous
    
    Preview Edit Formatting Help
    
    Cancel Add attachment
    You seem to have CSS turned off. Please don't fill out this field.
    
    You seem to have CSS turned off. Please don't fill out this field.

medoc
2017-09-27

Closing this as ohbuild.sh now fixes it (a bit more generic than having an rpm patch because it also does debian).

Reply
Link Attach

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Preview Edit Formatting Help
  
  Cancel Add attachment
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

medoc
2017-09-27
status: open --> closed

milestone: -->
Reply
Link Attach

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Preview Edit Formatting Help
  
  Cancel Add attachment
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous