#5 libupnp 1.6.24

None
closed
nobody
None
2018-01-22
2018-01-09
Anonymous
No

Hello,

I updated my arch linux installation on raspberry pi3 running upmpdcli (latest release). This updated libupnp from 1.6.22 to 1.6.24. This makes upmpdcli crash at startup. Recompiling upmpdcli did not help I had to downgrade libupnp. Could you please check that?

Best regards
Martin

Discussion

  • medoc
    medoc
    2018-01-10

    Thanks for reporting this.

    I can reproduce the crash, and the problem is fixed in libupnp git (2 small commits on branch 1.6).

    Maybe you could signal the package maintainer to add the patches to the package:

    commit 7af4e2ed0165c43bfa4bf9b3ffaa1ea925602662
    Author: Uwe Kleine-König uwe@kleine-koenig.org
    Date: Sun Dec 10 21:18:18 2017 +0100

    Fix assertion error when http_MakeMessage is called with E in fmt

An assert(0) is hit if fmt contains a char that is not expected. Support
for 'E' was added without making sure that this assert isn't reached.
This only hurts in debug builds and so shows that nobody tests these :-)

Fixes: 9c2e8ec8a029 ("extra headers")
Reported-by: Tobias Frost <tobi@coldtobi.de>

    commit 70e3d626378e12ea50d76dfda50311c8bb4a2a78
    Author: Jörg Krause joerg.krause@embedded.rocks
    Date: Tue Dec 5 11:29:44 2017 +0100

    Fix segmentation fault in http_MakeMessage

When upmpdcli is linked with libupnp 1.6.24 it fails with an
segmentation fault, but linking with libupnp worked just fine.

git bisect shows that commit 9c2e8ec8a0291ebe81959009e2f78edbdb47ced5 is
the bad one as the variable `extras` is not properly checked before
attempting to used it as a pointer.

Asure `extras` is not Null before using it.
     
    Reply
    Link Attach

  • medoc
    medoc
    2018-01-10

    • status: open --> closed
    • milestone: -->
     
    Reply
    Link Attach

  • Anonymous
    Anonymous
    2018-01-21

    There is an update to libupnp available in arch software repository now. upmpdcli works with that version again.

     
    Reply
    Link Edit
    Delete


    Attach

  • medoc
    medoc
    2018-01-22

    Thanks for the information. The patches were indeed already available in the pupnp git repo.

     
    Reply
    Link Attach

Anonymous
Anonymous

Preview Formatting Help

Cancel   Add attachment