It is now public String[] getRevisionsForDate(VcsRepository repository, Date date) throws Exception {
We noticed that one VcsProvider (git) returns an array of all revisions for the day, instead of a pair of first and last revision, and also in reverse order. There are tests for this by the way in SvnManagerTests, so no biggy but it is perhaps better to either split the method into getFirstRevisionForDate and getLastRevisionForDate or to create a RevisionRange class with getFirst() and getLast() methods.
Discussion
-
jrwilliams
2014-03-17- status: open --> accepted
- assigned_to: jrwilliams
