1.0
closed
nobody
None
2015-01-08
2015-01-08
gaixas1
No

I don't know if this problem has been fixed on any branch, but better say it.
With simple simulations I found that there was a constant increment of existing messages that weren't deleted.
After trying bigger tests, that ended crashing the simulator so I tried to correct it and found that both at DTP and Delimiting, when handling encapsulated messages, the container messages weren't deleted, so it results in a constant increment of existing messages and slow of execution.
For my tests, adding "delete msg;" at the end of "DTP::handleMsgFromRmt" and "Delimiting::handleMsgFromEfcpi" worked well.

Discussion

  • gaixas1
    gaixas1
    2015-01-08

    PD. Also it seems that FSUpdateInfo objects aren't deleted after the routing update is done.
    Adding "delete info;" after "fwdtg->handleUpdateMessage(info);" in "LisPDUFTGFwdInfoRecv::receiveSignal" should work, but first the line "info->remove(i);" of "FSUpdateInfo::disposeInfo()" should be removed as create an iterator error (removing the item to which the iterator points) and is not needed as the list is deleted after that (so deleting item by item would only be extra work).

     
  • Kewin Rausch
    Kewin Rausch
    2015-01-08

    Thank you for the feedback gaixas!

    I'm going to add the message disposal in the next release of the forwarding branch(I mean for the FSUpdateInfo stuff). :)

     
    Last edit: Kewin Rausch 2015-01-08
  • Marcel Marek
    Marcel Marek
    2015-01-08

    It is already fixed in our development branch, so please wait to the next commit.
    It should take place at the end of this week.

     
  • Marcel Marek
    Marcel Marek
    2015-01-08

    • status: open --> closed