jk would like you to merge 0 commits from /u/joerg-krause/sc2mpd/ to master
This merge requests adds support for using FLAC encoded audio streams. The usage of the FLAC codec is enabled by the command line option -C FLAC when starting the sender. The receiver automatically detects the required decoder.
Note, that using FLAC encoded audio streams breaks compatibility with the Openhome Protocol Specification which only defines PCM audio streams.
Nevertheless, using a FLAC encoded audio stream has the advantage of saving bandwith, which is essential in wireless networks.
| Commit | Date |
|---|
Discussion
-
medoc
2018-06-13Hi Joerg, this looks very fine and a great addition. The only thing I'm not liking too much is switching the ohSongcast repo. Is there a really compelling reason for this ? I'd actually rather manage a set of patches over the "official" repo, maybe adding a small patch queue mechanism to the ohbuild script. I think it would make it more obvious what the deviations are from Linn ohSongcast (which I understand is largely abandonned in favor of code inside ohPipeLine, but anyway).
-
medoc
2018-06-15I merged as is, I'll think about the repo issue later. In any case, a tar dist is used for packaging, so this is only an issue while developping.
I have a problem though, the commit which is set in ohbuild for ohSongcast does not exist on Github:
# Wed May 30 15:56:56 2018 +0200 git checkout c1cb53cce61e727b6096fc38d921802352b9f66b
I guess you forgot to push it ?
I used the following from May 29 instead for now:
Allow passing the halt and samples value to the audio message 9d886a67d08d42923537773b007dd7df11e52521
-
jk
2018-06-19Thanks for merging! Sorry about the commit from ohSongcast. It was correct to use the one you did.